-
-
Notifications
You must be signed in to change notification settings - Fork 265
[14.0][FIX] account_operating_unit: Manager can select all OUs #824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][FIX] account_operating_unit: Manager can select all OUs #824
Conversation
4e1698e to
55d63a1
Compare
Steps: 1. Create a Manager of Operating Units 2. Create some Operating Units 3. Log in as the created Manager 4. Create an Invoice 5. Click on the Operating Unit field Before this change: Not all Operating Units can be selected. After this change: All Operating Units can be selected.
55d63a1 to
8b23d50
Compare
Marco-ooops
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test funzionale ok
HekkiMelody
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review: LGTM
|
This PR has the |
|
@AaronHForgeFlow what do you think? Code and functional approved, we can fw-port |
|
@AaronHForgeFlow can we merge this? thanks! |
AaronHForgeFlow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Code review LGTM. I think the forward port is not needed, such domains do not exist in v15.
|
/ocabot merge minor |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 45f8e48. Thanks a lot for contributing to OCA. ❤️ |
Steps:
Before this change:
Not all Operating Units can be selected.
After this change:
All Operating Units can be selected.